Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark max1704x TAG const #661

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dankamongmen
Copy link

This allows us to use -wwrite-strings over the repo. Otherwise we get:

/home/dank/esp/build/_deps/espidflib-src/components/max1704x/max1704x.c:101:20: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  101 | static char *TAG = "max1704x";
      |                    ^~~~~~~~~~

@trombik
Copy link
Collaborator

trombik commented Oct 11, 2024

Do you think -wwrite-strings should be enabled by default?

@dankamongmen
Copy link
Author

Do you think -wwrite-strings should be enabled by default?

absolutely

@dankamongmen
Copy link
Author

but either way, this patch should be applied.

@dankamongmen
Copy link
Author

also, leaving this out means projects which include this project using the standard ESP-IDF CMake mechanism (like my project =]) can't use -wwrite-strings, which is annoying.

@trombik
Copy link
Collaborator

trombik commented Nov 2, 2024

@dankamongmen I am a co-maintainer of the repository and able to merge PRs. However, I always respect the repository owner's decision. So far, he has not commented. When he does, I will work on #663.

@dankamongmen
Copy link
Author

no worries, @trombik !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants