Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2024.2 detection (makes Undertale Yellow load again) #1748

Merged
merged 2 commits into from
May 2, 2024

Conversation

BenjaminUrquhart
Copy link
Member

@BenjaminUrquhart BenjaminUrquhart commented May 1, 2024

Description

Rooms with effects on their tile layers would trigger the 2024.2 check. This PR fixes that.

Copy link

github-actions bot commented May 1, 2024

@BenjaminUrquhart BenjaminUrquhart changed the title "Fix" 2024.2 detection (makes Undertale Yellow load again) Fix 2024.2 detection (makes Undertale Yellow load again) May 2, 2024
Copy link
Member

@colinator27 colinator27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussions on Discord, this check isn't necessarily exhaustive, but due to how unlikely it is for any real game to hit that check, it should be fine for now.

@colinator27 colinator27 merged commit 1fef615 into UnderminersTeam:master May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants