Add support for new bytecode weirdness #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some version between 2024.2 and before 2024.4 can include pushref.i in the function reference chain - WeirdLocalsFlag appears to be on for many code entries in 2024.2+, so this ensures locals are still disassembled when that happens (if any locals are present)
|
Download the artifacts for this pull request here: GUI:
CLI: |
BenjaminUrquhart
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caveats
There's a small chance this causes some existing games to have their code locals appear, but for the ones where it should matter (e.g., bytecode 14 and below), this doesn't seem to cause any problems.
Also, this does not have compiler support for the new pushref.i function stuff - only disassembler and decompiler. Not sure if it's worth doing for such a short-lived version, or if it has any tangible effect on the game or not.