Rename ClearDisplayBuffer to DoNotClearDisplayBuffer #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
colinator27
approved these changes
Jun 2, 2024
Jacky720
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1072
Was able to confirm that it's an issue by checking am2r's source code, which for this room has clearDisplayBuffer set to 0, but shows up in UTMT
Renaming the flag was the simplest thing I could think of of fixing it.
Caveats
API change. Every script which referenced that specific enum value (we dont have any in UTMT) will need to have their code adjusted.
Notes
N/A