Move 2.0.6 detection to object counting stage #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Jul 21, 2024
Miepee
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves 2.0.6 version detection to the object counting stage of deserialization. This fixes a regression with object counting that started occurring in a few GMS2 games after #1830 was merged, because the version was not detected early enough.
Caveats
Unlikely to have any side effects.
Notes
Tested on two games that had the issue, amongst a few that did not. Also, technically speaking, the 2.0.6 detection not occurring in the object counting stage was a hidden bug that could not be triggered until the aforementioned PR was merged.