Better dark mode #1992
Open
Better dark mode #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added WPFDarkTheme to the project, to replace the current dark mode, which doesn't use the proper theme system and doesn't work in many cases.
Caveats
I couldn't manage to make it switch between the new dark mode and the regular non-themed mode, there's glitches I don't fully understand. Because of that LightTheme.xaml is being used as the light mode, which looks different but looks acceptable to me.
There's also some small changes to be made, because some colors were hard coded in, should be easy as long as they are spotted.
Also messages boxes still aren't dark...
Notes
Lots of file changes since I had to both replace all the "Dark" variants of controls with the regular ones and make sure all Style tags have the BasedOn property, so they keep the theme going. I recommend looking at each commit to have a better idea of what's going on, if you want to.
Screenshot of this PR:
Screenshot of this PR in light mode:
Screenshot of bleeding edge, for reference: