Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The commutative ring of rational numbers #1107

Merged
merged 10 commits into from
Apr 11, 2024

Conversation

malarbol
Copy link
Contributor

This pull request introduces the commutative ring structure on the rational numbers.

We introduce:

  • left distributivity of multiplication over the addition of integer fractions;
  • (left|right) distributivity of multiplication over the addition of rational numbers (the last missing law for the ring structure);
  • (left|right) distributivity of multiplication over the difference of rational numbers;
  • a few laws about multiplication by zero in the rational numbers.

@malarbol
Copy link
Contributor Author

I'm back for more elementary-number-theory. Hopefully this new PR will be less work than the last one. It's quite small and the changes are pretty straightforward.

@malarbol malarbol changed the title The commutative ring rational numbers The commutative ring of rational numbers Apr 10, 2024
@fredrik-bakke
Copy link
Collaborator

Do you know why I usually write (left|right) by the way? It's because that's how you write the regex to match either word :)

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution! I don't have much to comment on.

Note that I reviewed this from my phone, so formatting errors are hard to catch

@malarbol malarbol force-pushed the ring-rational-numbers branch from a184725 to 18d3e40 Compare April 11, 2024 00:41
@VojtechStep
Copy link
Collaborator

There's a malformed link in elementary-number-theory.addition-rational-numbers to group-of-rational-numbers that we didn't catch in the last PR - @malarbol would you mind fixing it in this PR?

@fredrik-bakke
Copy link
Collaborator

Oh, did you implement all the requested changes, @malarbol? Is this ready to merge?

@malarbol
Copy link
Contributor Author

Oh, did you implement all the requested changes, @malarbol? Is this ready to merge?

I think I did (have a last check maybe?) and that it's ready to merge.

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fredrik-bakke
Copy link
Collaborator

I'll merge this right after #1096.

@fredrik-bakke fredrik-bakke enabled auto-merge (squash) April 11, 2024 15:54
@fredrik-bakke fredrik-bakke merged commit 511dadd into UniMath:master Apr 11, 2024
4 checks passed
@malarbol malarbol deleted the ring-rational-numbers branch May 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants