-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The commutative ring of rational numbers #1107
The commutative ring of rational numbers #1107
Conversation
I'm back for more |
Do you know why I usually write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent contribution! I don't have much to comment on.
Note that I reviewed this from my phone, so formatting errors are hard to catch
src/elementary-number-theory/multiplication-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/multiplication-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
a184725
to
18d3e40
Compare
src/elementary-number-theory/multiplication-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/multiplication-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/multiplication-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/multiplication-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
There's a malformed link in |
Oh, did you implement all the requested changes, @malarbol? Is this ready to merge? |
I think I did (have a last check maybe?) and that it's ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'll merge this right after #1096. |
This pull request introduces the commutative ring structure on the rational numbers.
We introduce: