Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from 𝔽 to Finite-* #1312

Merged
merged 14 commits into from
Feb 11, 2025
Merged

Switch from 𝔽 to Finite-* #1312

merged 14 commits into from
Feb 11, 2025

Conversation

fredrik-bakke
Copy link
Collaborator

No description provided.

@EgbertRijke
Copy link
Collaborator

Are all the extra lines of code just line breaks, or is there some hidden formalization work that I should be looking out for?

@fredrik-bakke
Copy link
Collaborator Author

This PR only renames things. The added lines are only because the names got longer.

@EgbertRijke
Copy link
Collaborator

Makes sense! Just asking what to expect

@fredrik-bakke
Copy link
Collaborator Author

By the way, not that I'm going to add further changes to this PR, but should UU-Fin rather be called Type-With-Finite-Cardinality?

@EgbertRijke
Copy link
Collaborator

By the way, not that I'm going to add further changes to this PR, but should UU-Fin rather be called Type-With-Finite-Cardinality?

That's a reasonable suggestion

@fredrik-bakke
Copy link
Collaborator Author

Did you finish your review last night or should I be expecting further comments?

@EgbertRijke EgbertRijke merged commit c0cfd7f into UniMath:master Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants