Also deprecate Python 3.8 #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our deprecation of Python 3.7 is a de-facto deprecation also of Python 3.8, since we will only explicitly target that and newer versions. The notes and changelogs should be more explicit about this.
johannaengland
approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2919 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 602 602
Lines 44084 44084
=======================================
Hits 26565 26565
Misses 17519 17519 ☔ View full report in Codecov by Sentry. |
Test results 12 files 12 suites 11m 53s ⏱️ Results for commit e12a6fd. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our deprecation of Python 3.7 is a de-facto deprecation also of Python 3.8, since we will only explicitly target that and newer versions. The notes and changelogs should be more explicit about this.