Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate database rule netbox_close_arp and delete netbox_status_close_arp instead #2928

Merged
merged 1 commit into from
May 30, 2024

Conversation

lunkwill42
Copy link
Member

@lunkwill42 lunkwill42 commented May 30, 2024

Unfortunately, #2913 (43d5543) deleted the incorrect database rule and made it into a release. This reinstates the rule, ensures data integrity and deletes the correct rule: netbox_status_close_arp

Fixes #2910

43d5543 deleted the incorrect database
rule and made it into a release.  This reinstates the rule, ensures
data integrity and deletes the *correct* rule: `netbox_status_close_arp`
@lunkwill42 lunkwill42 added the bug label May 30, 2024
@lunkwill42 lunkwill42 requested a review from a team May 30, 2024 05:55
@lunkwill42 lunkwill42 self-assigned this May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.27%. Comparing base (4797ef5) to head (9d1eb2d).
Report is 8 commits behind head on 5.10.x.

Additional details and impacted files
@@           Coverage Diff           @@
##           5.10.x    #2928   +/-   ##
=======================================
  Coverage   60.27%   60.27%           
=======================================
  Files         602      602           
  Lines       44099    44099           
=======================================
  Hits        26580    26580           
  Misses      17519    17519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 30, 2024

Test results

     12 files       12 suites   12m 8s ⏱️
3 326 tests 3 326 ✔️ 0 💤 0
9 453 runs  9 453 ✔️ 0 💤 0

Results for commit 9d1eb2d.

♻️ This comment has been updated with latest results.

@lunkwill42 lunkwill42 changed the base branch from master to 5.10.x May 30, 2024 06:11
@lunkwill42 lunkwill42 merged commit b3e3b01 into 5.10.x May 30, 2024
18 checks passed
@lunkwill42 lunkwill42 deleted the bugfix/delete-correct-arp-closure-rule branch May 30, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants