Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F401 (unused imports) rule to ruff config #3026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 25, 2024

This is just my suggestion. so please add your opinion if and why you think this is not a great idea.

@johannaengland johannaengland added the discussion Requires developer feedback/discussion before implementation label Sep 25, 2024
@johannaengland johannaengland self-assigned this Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 991 0 13.23s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Sep 25, 2024

Test results

    9 files      9 suites   8m 40s ⏱️
2 139 tests 2 139 ✅ 0 💤 0 ❌
4 017 runs  4 017 ✅ 0 💤 0 ❌

Results for commit a2d2618.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (c61be8e) to head (a2d2618).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3026   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         605      605           
  Lines       43688    43688           
  Branches       48       48           
=======================================
  Hits        26384    26384           
  Misses      17292    17292           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@johannaengland johannaengland changed the base branch from master to cleanup/add-noqa-to-necessary-unused-imports September 27, 2024 09:06
@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch from f4eaae2 to 2a2c093 Compare September 27, 2024 09:07
Copy link

sonarcloud bot commented Sep 27, 2024

@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch 2 times, most recently from e0fed99 to afbe765 Compare November 22, 2024 09:41
Base automatically changed from cleanup/add-noqa-to-necessary-unused-imports to master November 22, 2024 09:51
Copy link

sonarcloud bot commented Nov 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires developer feedback/discussion before implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants