Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused error variables #3028

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

johannaengland
Copy link
Contributor

As a preparation to add F841 to ruff

Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

github-actions bot commented Sep 25, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 991 0 12.74s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Sep 25, 2024

Test results

    9 files      9 suites   8m 25s ⏱️
2 139 tests 2 139 ✅ 0 💤 0 ❌
4 017 runs  4 017 ✅ 0 💤 0 ❌

Results for commit 09c4d7e.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (518b252) to head (09c4d7e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3028   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         605      605           
  Lines       43688    43688           
  Branches       48       48           
=======================================
  Hits        26384    26384           
  Misses      17292    17292           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

python/nav/eventengine/topology.py Outdated Show resolved Hide resolved
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johannaengland johannaengland force-pushed the cleanup/remove-unused-error-variables branch from a48f4aa to 09c4d7e Compare November 22, 2024 09:53
Copy link

sonarcloud bot commented Nov 22, 2024

@johannaengland johannaengland merged commit c61be8e into master Nov 22, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the cleanup/remove-unused-error-variables branch November 22, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants