-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove now unused crispy LabelSubmit #3094
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 43s ⏱️ Results for commit 6aeb8bf. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3094 +/- ##
==========================================
+ Coverage 60.39% 60.42% +0.02%
==========================================
Files 605 605
Lines 43704 43701 -3
Branches 48 48
==========================================
+ Hits 26396 26406 +10
+ Misses 17296 17283 -13
Partials 12 12 ☔ View full report in Codecov by Sentry. |
8ad502e
to
63fde94
Compare
3526bee
to
ddba526
Compare
Quality Gate passedIssues Measures |
2093397
to
a786816
Compare
a786816
to
1f05e1f
Compare
ddba526
to
2e0179b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good so far, but we also can now remove the class itself
nav/python/nav/web/crispyforms.py
Line 24 in 2e0179b
class LabelSubmit(Submit): |
Huh, that somehow got lost during rebasing, thanks for noticing! |
Nice! |
This has been replaced by SubmitField setting has_empty_label to True
79f3824
to
6aeb8bf
Compare
Quality Gate passedIssues Measures |
Dependent on #3078.