Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unused crispy LabelSubmit #3094

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Oct 4, 2024

Dependent on #3078.

Copy link

github-actions bot commented Oct 4, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.16s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 4, 2024

Test results

    9 files      9 suites   8m 43s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 6aeb8bf.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.42%. Comparing base (3f0faab) to head (6aeb8bf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
+ Coverage   60.39%   60.42%   +0.02%     
==========================================
  Files         605      605              
  Lines       43704    43701       -3     
  Branches       48       48              
==========================================
+ Hits        26396    26406      +10     
+ Misses      17296    17283      -13     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland changed the title Cleanup/remove label submit Remove now unused crispy LabelSubmit Oct 7, 2024
@johannaengland johannaengland force-pushed the refactor/uncrispify-management-profile-filter-form branch from 8ad502e to 63fde94 Compare October 7, 2024 13:29
Base automatically changed from refactor/uncrispify-management-profile-filter-form to master October 8, 2024 06:41
@johannaengland johannaengland changed the base branch from master to refactor/uncrispify-activity-interval-form-ipdevinfo October 8, 2024 10:29
Copy link

sonarcloud bot commented Oct 8, 2024

@johannaengland johannaengland force-pushed the refactor/uncrispify-activity-interval-form-ipdevinfo branch from 2093397 to a786816 Compare October 11, 2024 06:58
@johannaengland johannaengland force-pushed the refactor/uncrispify-activity-interval-form-ipdevinfo branch from a786816 to 1f05e1f Compare November 7, 2024 13:00
Base automatically changed from refactor/uncrispify-activity-interval-form-ipdevinfo to master November 7, 2024 13:27
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far, but we also can now remove the class itself

class LabelSubmit(Submit):

@johannaengland
Copy link
Contributor Author

Good so far, but we also can now remove the class itself

class LabelSubmit(Submit):

Huh, that somehow got lost during rebasing, thanks for noticing!

@podliashanyk
Copy link
Contributor

Nice!

This has been replaced by SubmitField setting has_empty_label to True
Copy link

sonarcloud bot commented Nov 13, 2024

@johannaengland johannaengland merged commit 8bc62b0 into master Nov 13, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the cleanup/remove-label-submit branch November 13, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants