Uncrispify all of seedDB #3128
Merged
Uncrispify all of seedDB #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 32s ⏱️ Results for commit f9e31db. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
- Coverage 60.39% 60.39% -0.01%
==========================================
Files 605 605
Lines 43708 43704 -4
Branches 48 48
==========================================
- Hits 26399 26396 -3
+ Misses 17297 17296 -1
Partials 12 12 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 10, 2024
johannaengland
force-pushed
the
refactor/uncrispify-seeddb
branch
from
6e3ace3
to
aac8716
Compare
johannaengland
changed the base branch from
master
to
refactor/uncrispify-prefix-vlan-form-in-seeddb
Base automatically changed from
refactor/uncrispify-prefix-vlan-form-in-seeddb
to
master
October 16, 2024 12:24
johannaengland
force-pushed
the
refactor/uncrispify-seeddb
branch
from
aac8716
to
e9c9300
Compare
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
All SeedDB forms are uncrispified by now
They can be removed since they do not set anything
johannaengland
force-pushed
the
refactor/uncrispify-seeddb
branch
from
e9c9300
to
f9e31db
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2996.