-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncrispify AccountForm
in useradmin
#3168
Uncrispify AccountForm
in useradmin
#3168
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
f39d574
to
4d3a367
Compare
Test results 9 files 9 suites 8m 36s ⏱️ Results for commit 1091e15. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
- Coverage 60.40% 60.39% -0.01%
==========================================
Files 605 605
Lines 43698 43690 -8
Branches 48 48
==========================================
- Hits 26395 26386 -9
- Misses 17291 17292 +1
Partials 12 12 ☔ View full report in Codecov by Sentry. |
4d8eea0
to
2af3c24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 👍
See a suggestion below
python/nav/web/templates/useradmin/frag-external-account-fieldset.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small comments
1091e15
to
add0dff
Compare
External means managed by ldap for example and internal is a user made by nav
The information box about externally managed accounts is moved into HTML templates
add0dff
to
075c26b
Compare
Quality Gate passedIssues Measures |
Closes #3135.
This is quite a bit more complicated of a refactor. So I would suggest reading it commit by commit.
The form can look four different ways:
Urls (when using a dump of the sikt-vk):
http://localhost/useradmin/account/new/ (1. New user)
http://localhost/useradmin/account/0/ (2. Default user)
http://localhost/useradmin/account/1/ (3. Normal user)
http://localhost/useradmin/account/1093/ (4. External user)
As already in the code suggested I split these forms up into two different forms:
AccountForm
for use cases 1-3 andExternalAccountForm
for use case 4.@podliashanyk and I made the decision to move the blue "External authenticator" box to the top of the fieldset, that made it much easier to override the template and makes it look more cohesive
Screenshots of that change:
Previously:
Now: