Remove fallback form rendering from uncrispified forms

[johannaengland]

We decided that the template web/templates/custom_crispy_templates/_form_content.html has enough fallback by itself

For more information see #3140 and #3157.

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	992		0	11.14s
✅ PYTHON	ruff	987		0	0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[github-actions]

Test results

    9 files      9 suites   8m 21s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 835e11c.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (8bc62b0) to head (835e11c).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         605      605           
  Lines       43701    43701           
  Branches       48       48           
=======================================
  Hits        26393    26393           
  Misses      17296    17296           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[podliashanyk]

Nice! See comments below.

And seems like self.attrs = set_flat_form_attributes() is redundant in DeviceGroupForm as well?

[johannaengland]

Yes, I believe we can remove calls to set_flat_form_attributes without parameters. But I would do that in another PR, will do that soon!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud