Remove crispy-forms-foundation and django-crispy-forms from requirements

[johannaengland]

Removes crispy-forms-foundation and django-crispy-forms from requirements and necessary settings for those. Also changes some wording to not directly reference crispy

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	991		0	12.84s
✅ PYTHON	ruff	987		0	0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[github-actions]

Test results

    9 files      9 suites   8m 16s ⏱️
2 139 tests 2 139 ✅ 0 💤 0 ❌
4 017 runs  4 017 ✅ 0 💤 0 ❌

Results for commit 05a6651.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (6f508a6) to head (05a6651).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3211      +/-   ##
==========================================
- Coverage   60.39%   60.39%   -0.01%     
==========================================
  Files         605      605              
  Lines       43685    43683       -2     
  Branches       48       48              
==========================================
- Hits        26383    26381       -2     
  Misses      17290    17290              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[stveit]

nav/python/nav/web/templates/foundation-5/README.txt

Line 1 in 3034cd5

Place templates for globally overriding crispy_forms_foundation templates in this directory.

reference here to crispy_forms_foundation

[johannaengland]

nav/python/nav/web/templates/foundation-5/README.txt

Line 1 in 3034cd5

Place templates for globally overriding crispy_forms_foundation templates in this directory.

reference here to crispy_forms_foundation

True, generally the folder foundation-5 should get a new name or be merged with custom_crispy_templates.

I'll create a new issue for that since I think @podliashanyk better knows how to order the templates

#3216

[stveit]

It doesnt seem like this breaks anything, but more people should test

[lunkwill42]

Closes #2794.

Is that correct? There is still at least one unchecked checkbox on #2794, and this PR does not alone close all of #2794...

[lunkwill42]

The changes by themselves seem fine to me. All tests are green, and there doesn't seem to be any significant references to crispy-forms left in the codebase.

I'd like to see an entry about removed dependencies in NOTES.rst, though :)

[lunkwill42]

Sorry, accidentally pushed two more commits to the wrong branch - reset and force-pushed back to the last commit before my mistake.

[johannaengland]

I'd like to see an entry about removed dependencies in NOTES.rst, though :)

I thought NOTES.rst will be updated when creating a release since we switched to towncrier?

[lunkwill42]

I'd like to see an entry about removed dependencies in NOTES.rst, though :)

I thought NOTES.rst will be updated when creating a release since we switched to towncrier?

NOTES.rst are our project release notes. We use it to communicate changes and necessary actions to take during upgrades. towncrier has no bearing on that file: It is always authored by humans on a case-by-case basis. Have you read it? :-) I usually edit it at release-time, but it is much easier to forget to add stuff to it if it isn't done continuously.

We usually make a subsection of dependency changes for each release.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud