Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alert profiles match value dropdown lists searchable using select2 #3240

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

lunkwill42
Copy link
Member

@lunkwill42 lunkwill42 commented Nov 24, 2024

This makes multiple choice drop down lists in Alert Profiles filter searchable using select2, which makes it a lot easier to find desired values when the choice lists become huge.

Fixes #3238

Url: http://localhost/alertprofiles/filters/add-expression/

Screenshot

image

This makes multiple choice drop down lists in Alert Profiles filter
searchable using select2, which makes it a lot easier to find desired
values when the choice lists become huge.
@lunkwill42 lunkwill42 self-assigned this Nov 24, 2024
@lunkwill42 lunkwill42 requested a review from a team November 24, 2024 14:00
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 991 0 12.77s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

Test results

    9 files      9 suites   8m 23s ⏱️
2 139 tests 2 139 ✅ 0 💤 0 ❌
4 017 runs  4 017 ✅ 0 💤 0 ❌

Results for commit 694461e.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (27b12b5) to head (694461e).
Report is 65 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3240   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         605      605           
  Lines       43687    43684    -3     
  Branches       48       48           
=======================================
- Hits        26383    26382    -1     
+ Misses      17292    17290    -2     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lunkwill42 lunkwill42 merged commit ca06bd3 into master Nov 29, 2024
14 checks passed
@lunkwill42 lunkwill42 deleted the feature/alertprofiles-searchable-dropdowns branch November 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Alert Profiles filter expression drop down lists searchable
2 participants