-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize logging of various SNMP traps just as Zino 1 does #320
Conversation
Also adds dumps of all MIB depdencies that weren't already included in Zino.
Logs `ciscoPimInvalidRegister` and `ciscoPimInvalidJoinPrune` just like Zino 1 does.
Including MIB dependencies.
As in Zino 1, this just logs the values of all included varbinds whose named start with the string `ospf`
Remove trap log details from non-implemented features list.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 3 files 3 suites 1m 25s ⏱️ Results for commit 1c628bf. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 97.31% 98.49% +1.18%
==========================================
Files 64 77 +13
Lines 7888 9686 +1798
==========================================
+ Hits 7676 9540 +1864
+ Misses 212 146 -66 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
0bfbb7a
to
b8f1889
Compare
As suggested in code review. Co-authored-by: Johanna England <[email protected]>
b8f1889
to
1c628bf
Compare
Quality Gate passedIssues Measures |
Scope and purpose
Fixes #319
This pull request
logged_traps
module, one for each MIB mentioned in Add custom trap logging #319zino.mibdumps
package, in order to be able to resolve trap names and variables.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.