Clean up issues with IP address parsing in several places #322
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 3 files 3 suites 1m 23s ⏱️ Results for commit ee31ed7. ♻️ This comment has been updated with latest results. |
|
I have not tested this extensively against real-world equipment, as I ran out of time: Gotta go on vacation :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 98.57% 98.61% +0.05%
==========================================
Files 77 77
Lines 9699 9671 -28
==========================================
- Hits 9560 9537 -23
+ Misses 139 134 -5 ☔ View full report in Codecov by Sentry. |
|
|
So, have any of you tested, @stveit or @johannaengland , or I should I go ahead? I see I have a potential uncommitted simplification of the BGP trap processing code that would parse an IP address as well... |
I have not. But I remember @stveit saying in a standup meeting last week that he was planning on testing it |
|
Zino seems to be running fine with these changes from what I can tell |
PySNMP doesn't necessarily pretty-print InetAddress and IpAddress value types as anything useful for us (This are textual conventions of an OctetString, and PySNMP tends to just raw-dog the octet string into something like a hexadecimal string representation of the content). If the value type is `InetAddress` or `IpAddress` we can expect `ipaddress.ip_address()` to properly parse the raw bytes into an IPv4Address or IPv6Address object.
`InetAddress` and `IpAddress` MIB values are now expected to be returned as IPv4Address or IPv6Address objects from the SNMP layer.
The BGP state monitor task would test for membership in this list using IPv4Address or IPv6Address objects, but the list contained raw strings, so the tests would never match.
lunkwill42
force-pushed
the
feature/translate-ip-values-at-lower-level
branch
from
3da1744
to
eedf00b
Compare
|
I rebased this on the latest master due to conflicts. Have tested myself against real-world equipment now and found no issues. |
lunkwill42
force-pushed
the
feature/translate-ip-values-at-lower-level
branch
from
eedf00b
to
94bba1d
Compare
lunkwill42
force-pushed
the
feature/translate-ip-values-at-lower-level
branch
from
94bba1d
to
ee31ed7
Compare
|
Scope and purpose
Mainly this fixes the issue of parsing the values of
InetAddressandIpAddresstype MIB objects at the level of thezino.snmp._mib_value_to_python()function. Once fixed there, using theparse_iputility function becomes superfluous, so these instances can be removed.There was also some strange issue with comparing strings to IP address objects which was resolved.
There may be similar updates to had in the trap observers (some of which parse the raw object values for IP address itself).
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.