Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polldevs dictionary to Zino1BaseServerProtocol instances #326

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

Fixes #309.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
    • internal change, so no changelog fragment needed
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (70fc24b) to head (54aa3ef).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          77       77           
  Lines        9687     9687           
=======================================
  Hits         9551     9551           
  Misses        136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! The less patching we have to do, the cleaner the tests are :)

@johannaengland johannaengland force-pushed the cleanup/add-polldevs-to-server-protocol branch from c32ffa0 to 54aa3ef Compare August 21, 2024 06:44
Copy link

sonarcloud bot commented Aug 21, 2024

@johannaengland johannaengland merged commit 1cc5355 into Uninett:master Aug 21, 2024
7 of 8 checks passed
@johannaengland johannaengland deleted the cleanup/add-polldevs-to-server-protocol branch August 21, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add polldevs dictionary to Zino1BaseServerProtocol instances
2 participants