-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only load and parse pollfile if it has changed since last loading #327
Only load and parse pollfile if it has changed since last loading #327
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 98.20% 98.27% +0.07%
==========================================
Files 64 64
Lines 7930 8029 +99
==========================================
+ Hits 7787 7890 +103
+ Misses 143 139 -4 ☔ View full report in Codecov by Sentry. |
06ada60
to
75f26df
Compare
75f26df
to
fefada5
Compare
I have rebased this instead of adding more commit because I have rethought how to access the saved attribute of when the poll file was last modified. |
126f35e
to
dd1f040
Compare
This will be used to determine if the pollfile has been modified since the last read
dd1f040
to
5e6d96d
Compare
This should rarely/never happen, since we check for the existence of the pollfile when loading the config and earlier in the same function, but better safe than sorry
5e6d96d
to
5987e68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Still, let me throw some nit-picks at you :)
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might still consider factoring out the timestamp checking to a separate function, but this will definitely do :)
Runar's suggestion has been fixed.
Scope and purpose
Fixes #282. Dependent on #345.
Add a description of what this PR does and why it is needed. If a linked ticket(s) fully
cover it, you can omit this.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.