Use default interval from pollfile to stagger new jobs #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 64 64
Lines 7926 7930 +4
=======================================
+ Hits 7783 7787 +4
Misses 143 143 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
bugfix/use-default-interval-pollfile-to-stagger-first-jobs
branch
from
b1b386d
to
72902a6
Compare
stveit
reviewed
Aug 2, 2024
runborg
requested changes
Aug 5, 2024
runborg
approved these changes
Aug 8, 2024
stveit
approved these changes
Aug 8, 2024
This is in preparation of having it also return the defaults separately And the result was always cast to a list or dict anyway
johannaengland
force-pushed
the
bugfix/use-default-interval-pollfile-to-stagger-first-jobs
branch
from
784825b
to
d39c701
Compare
johannaengland
force-pushed
the
bugfix/use-default-interval-pollfile-to-stagger-first-jobs
branch
from
d39c701
to
a3300ec
Compare
|
johannaengland
deleted the
bugfix/use-default-interval-pollfile-to-stagger-first-jobs
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #337.
Changed the way that
read_polldevswork to make it easier to return thePollDevicesand the default values. I was considering splitting the function in two: One to read the defaults and one to read the rest - the poll devices, but decided for this method, since it is simpler changes.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.