-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ifalias for Planned Maintenance "str" and "regexp" matching #340
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 3 files 3 suites 1m 17s ⏱️ Results for commit a966ba4. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 64 64
Lines 7926 7930 +4
=======================================
+ Hits 7783 7787 +4
Misses 143 143 ☔ View full report in Codecov by Sentry. |
71d251c
to
216e1d7
Compare
216e1d7
to
2fb292e
Compare
I would like to have a news fragment for that, because this is a functionality change |
Did another look on original code, and seems it uses both ifalias and ifdescr in different situations. I have changed things to reflect that |
03a6a83
to
269c244
Compare
269c244
to
8bc275a
Compare
|
Scope and purpose
Fixes #297
Original zino seems to use ifalias and ifdescr for planned maintenance matching, while intitial PM implementation used only ifdescr.
This PR changes it to use ifalias where applicable instead.
Original zino code confuses me so wouldn't be a bad idea for someone else to take a look and see if this PR actually makes the correct changes
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.