Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use current network name in Gas Breakdown tooltip #7292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use current network name in Gas Breakdown tooltip #7292

wants to merge 1 commit into from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Sep 10, 2023 •
edited
Loading

Description

Fixes the GasBreakdownTooltip to use the current network name instead of the hardcoded "Ethereum network" text

Screen capture

Before

SCR-20230910-jjcu

After

SCR-20230910-jgkq

Test plan

Reproducing the error

  1. Switch to any non-EthereumMainnet network
  2. Go to Swaps
  3. Select "to" and "from" tokens
  4. Wait for the the gas estimate icon to display
  5. Hover of the gas estimate icon to see the GasBreakdownTooltip
  6. Ensure that the network name matches the current network

QA (ie manual testing)

  • N/A

Devices

Automated testing

  • Unit test
  • Integration/E2E test

@darkwing darkwing requested review from a team and natew September 10, 2023 15:10
@vercel
Copy link

vercel bot commented Sep 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 1:51am

@darkwing darkwing requested a review from tinaszheng September 18, 2023 22:34
@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #7292 (75f12b3) into main (5fee3c6) will decrease coverage by 2.43%.
The diff coverage is 100.00%.

❗ Current head 75f12b3 differs from pull request most recent head 1bde62e. Consider uploading reports for the commit 1bde62e to get more accurate results

Flag Coverage Δ
cloud-tests 87.27% <ø> (+3.66%) ⬆️
unit-tests 40.28% <100.00%> (-2.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@just-toby
Copy link
Contributor

this is a duplicate of #6979 but we'll probably merge whichever one updates first

@just-toby
Copy link
Contributor

@darkwing can you rebase and fix conflicts?

@darkwing darkwing force-pushed the fix-swap-gas-breakdown-network-name branch from 75f12b3 to 1bde62e Compare October 12, 2023 01:49
@darkwing
Copy link
Contributor Author

Updated as requested!

@zzmp zzmp added the reference Reference PR label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-toby just-toby just-toby approved these changes

@natew natew natew approved these changes

@tinaszheng tinaszheng Awaiting requested review from tinaszheng

Assignees
No one assigned
Labels
reference Reference PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darkwing @just-toby @natew @tinaszheng @zzmp