Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix sitemaps routes test #7441

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: fix sitemaps routes test #7441

merged 2 commits into from
Oct 11, 2023

Conversation

kristiehuang
Copy link
Contributor

@kristiehuang kristiehuang commented Oct 10, 2023 •
edited
Loading

sitemap URLs should exist as Router paths - should test that routerPaths contain each sitemap URL, not vice versa

Context: we are adding Router paths that aren't publicly-available yet

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 9:05pm

@kristiehuang kristiehuang marked this pull request as ready for review October 10, 2023 20:52
@kristiehuang kristiehuang requested review from a team and tinaszheng October 10, 2023 20:52
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #7441 (c42112b) into main (45c3e1d) will increase coverage by 0.10%.
The diff coverage is n/a.

Flag Coverage Δ
cloud-tests 83.60% <ø> (?)
unit-tests 42.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 10, 2023 •
edited
Loading

5 flaky tests on run #14950 ↗︎

0 118 0 0 Flakiness 5

Details:

fix: fix sitemaps routes test
Project: Uniswap Interface Commit: c42112b7df
Status: Passed Duration: 05:02 💡
Started: Oct 10, 2023 9:08 PM Ended: Oct 10, 2023 9:13 PM
Flakiness  swap/uniswapx.test.ts • 4 flaky tests • e2e

View Output Video

Test Artifacts
UniswapX Toggle > prompts opt-in if UniswapX is better Output Screenshots
UniswapX Orders > renders proper view if uniswapx order expires Output Screenshots
UniswapX Eth Input > switches swap input to WETH after wrap Output Screenshots
UniswapX activity history > can view UniswapX order status progress in activity upon expiry Output Screenshots
Flakiness  permit2.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
Permit2 > prompts signature when existing permit approval is expired Output Screenshots

Review all test suite changes for PR #7441 ↗︎

@kristiehuang kristiehuang merged commit b75438b into main Oct 11, 2023
23 checks passed
@kristiehuang kristiehuang deleted the fix-sitemaps-routes-test branch October 11, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-toby just-toby just-toby approved these changes

@gnewfield gnewfield gnewfield approved these changes

@cbachmeier cbachmeier cbachmeier approved these changes

@mattbspector mattbspector mattbspector approved these changes

@tinaszheng tinaszheng Awaiting requested review from tinaszheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kristiehuang @mattbspector @cbachmeier @gnewfield @just-toby