fix: user prop updater staging #7443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tinaszheng
approved these changes
Oct 10, 2023
| useEffect(() => { | ||
| // User properties *must* be set before sending corresponding event properties, | ||
| // so that the event contains the correct and up-to-date user properties. | ||
| user.set(CustomUserProperties.USER_AGENT, navigator.userAgent) |
There was a problem hiding this comment.
are we sure these are also ok to move into the statsig provider? 👀 might run into the issue of these use effects running at the same time as other ones that send events I think? nbd would just keep an eye on it
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
mattbspector
approved these changes
Oct 10, 2023
5 flaky tests on run #14956 ↗︎
Details:
|
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
staging hotfix for #7442