fix: update uniwallet wc link #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Passing run #15350 ↗︎
Details:
Review all test suite changes for PR #7450 ↗︎ |
|||||||||||||||
|
Can you leave this as a draft until uniwallet v1.15 is released? |
cartcrom
reviewed
Oct 12, 2023
mattbspector
approved these changes
Nov 6, 2023
cbachmeier
requested changes
Nov 6, 2023
just-toby
force-pushed
the
fix/new-wc-uniwallet-url
branch
from
393902f to
83c3d94
Compare
|
@cbachmeier @cartcrom good points, we don't want to change the redirect URL ! just the QR code one. i just updated and tested the 3 cases in the description to verify it's working as expected |
cbachmeier
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
!! this should not be merged until uniwallet v1.15 is released !!
just updates the WalletConnect URI schema as requested by the mobile team. see the slack message below for details. according to that message, this new schema will result in the behavior:
Linear ticket: https://linear.app/uniswap/issue/WEB-2982/update-the-url-for-wc-scan
Slack thread: https://uniswapteam.slack.com/archives/C03JG5E8N4B/p1696948339018599?thread_ts=1695999340.625809&cid=C03JG5E8N4B
Test plan
QA (ie manual testing)
Devices