fix: change default tx deadline to 10m #7451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
3 flaky tests on run #14985 ↗︎
Details:
|
|||||||||||||||
cbachmeier
approved these changes
Oct 11, 2023
tinaszheng
pushed a commit
that referenced
this pull request
Oct 13, 2023
* fix: change deadline to 10m * test: add unit tests * fix: improve unit tests
tinaszheng
added a commit
that referenced
this pull request
Oct 13, 2023
fix: change default tx deadline to 10m (#7451) * fix: change deadline to 10m * test: add unit tests * fix: improve unit tests Co-authored-by: eddie <[email protected]>
tinaszheng
added a commit
that referenced
this pull request
Oct 13, 2023
* fix: change default tx deadline to 10m (#7451) * fix: change deadline to 10m * test: add unit tests * fix: improve unit tests * feat: Remove local routing setting (#7462) * remove client side router preference * update e2e test * fix comment --------- Co-authored-by: eddie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates the default deadline from 30 minutes (1800 seconds) to 10 minutes (600 seconds). this includes changing the constant value used to seed the default state, but also includes a migration for all users who had the old default value persisted.
Linear ticket: https://linear.app/uniswap/issue/WEB-2938/30m-feels-high-for-classic-swaps-xinwan-and-austinadams-can-weigh-in
Relevant docs: https://www.notion.so/Redux-migrations-in-interface-30aca899626a4ac4af7b070f92ce976d
Test plan
QA (ie manual testing)
user.userDeadlinehad the new default value saved in my IndexedDBAutomated testing