Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sitemap format #7453

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: sitemap format #7453

merged 1 commit into from
Oct 11, 2023

Conversation

just-toby
Copy link
Contributor

Description

the old format was valid according to free sitemap validators, but Google Search Console seems to prefer this format.

@just-toby just-toby requested review from a team and tinaszheng October 11, 2023 20:01
@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 8:03pm

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #7453 (70b77e7) into main (40b1e40) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 42.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 11, 2023

3 flaky tests on run #14991 ↗︎

0 118 0 0 Flakiness 3

Details:

fix: sitemap format
Project: Uniswap Interface Commit: 70b77e7998
Status: Passed Duration: 05:36 💡
Started: Oct 11, 2023 8:07 PM Ended: Oct 11, 2023 8:13 PM
Flakiness  cypress/e2e/swap/uniswapx.test.ts • 3 flaky tests • e2e

View Output Video

Test Artifacts
UniswapX Toggle > prompts opt-in if UniswapX is better Output Screenshots
UniswapX Orders > can swap exact-in trades using uniswapX Output Screenshots
UniswapX activity history > can view UniswapX order status progress in activity upon expiry Output Screenshots

Review all test suite changes for PR #7453 ↗︎

Copy link
Contributor

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a line limit for sitemaps?

@just-toby
Copy link
Contributor Author

Is there a line limit for sitemaps?

the limit is 50,000 URLs or 50MB, whichever comes first

@just-toby just-toby merged commit 5fee3c6 into main Oct 11, 2023
23 checks passed
@just-toby just-toby deleted the fix/sitemap-format branch October 11, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants