fix: routing dashboard to include uniswap-extension #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
xrsv,
uni-guillaume,
mikeki,
cgkol and
a team
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (07/16/24)1 assignee was added and 6 reviewers were added to this PR based on 's automation. |
cgkol
approved these changes
Jul 16, 2024
I think because the dashboard code, it doesn't have a way to know all the possible request sources during runtime, which is populated within quote handler. |
jsy1218
deleted the
siyujiang/route-184-fix-routing-dashboard-to-include-uniswap-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routing dashboard doesn't show uniswap-extension, however metrics show:
This is because the request source array in routing-api didn't include
uniswap-extension.