Fix #3192: Reloading With --update-env Option #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rambo-panda
reviewed
Nov 16, 2024
| delete opts.env.current_conf.env | ||
| // NOTE: `env` gets overriden by `Utility.extendMix` call. Instead, we want to merge envs. | ||
| if (opts.env.current_conf.env && typeof(opts.env.current_conf.env) === 'object') | ||
| Utility.extendMix(proc.pm2_env.env, opts.env.current_conf.env); |
There was a problem hiding this comment.
Should we add an proc.pm2_env.env.updateEnv check here?
if (proc.pm2_env.env.updateEnv) {
Utility.extend(proc.pm2_env.env, opts.env.current_conf.env);
}There was a problem hiding this comment.
AFAIK no, because the env won't be extended with the new variables here:
Line 1362 in 304fc5e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first bug fix for pm2. I've been struggling with the issue described in #3192 for a long time. Previously, I used the following hack to make it work properly:
After reviewing the code, I believe I have found the actual cause of this bug. The environment gets overriden due to a wrong object extension in
Utility.extendExtraConfig.I'm open to any suggestions for improvements.