Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/contributing #129

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

selgueti
Copy link
Contributor

@selgueti selgueti commented Sep 9, 2022

Description

Update contribution guide

Type of files

  • bin: Binary files
  • ci: Continuous integration files
  • doc: Documentation files
  • Plain-text source code files

Level of change

  • break: Breaking change
  • exp: Experimental change
  • tmp: Temporal change
  • major: Major change
  • minor: Minor change
  • revert: Revert a commit change
  • sec: Vulnerability-related change
  • None of the above (normal change)

Type of change

  • deprecat: Deprecation of a once-stable feature
  • enhance: Enhancement in existing functionality
  • fix: Bug fix
  • feature: New feature
  • hotfix: Hotfix for bugs
  • refactor: Improve coding style, comments
  • remove: Remove a feature

Checklist:

  • My code compiles
  • My code does not generate new warnings
  • My code only implements a single fix or feature
  • My code follows the code style of this project
  • My code includes javadoc/doxygen where appropriate
  • My code is well factored, so that there is not repetitive code in the wild
  • My code does not refactor the surrounding code unless necessary
  • My code does not require a change in the documentation, if so I already opened an issue to list the changes
  • I have read the CONTRIBUTING document
  • I have read the Pull Request/Commit Message Guidelines
  • I have given a clear and concise title to my pull request following the above guidelines
  • I understand that all commits on my pull request will be squashed to a single good one
  • All above points were checked and are marked

@pullapprove pullapprove bot requested a review from gvollant September 9, 2022 15:19
Copy link
Member

@martinec martinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that Multi2Delaf.cpp and Multi2Delaf.h do not meet the intent of the PR. Can you confirm this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants