-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: fixed gamepad navigation in UI Toolkit TextField #2103
base: develop
Are you sure you want to change the base?
FIX: fixed gamepad navigation in UI Toolkit TextField #2103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, thanks for addressing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it doesn't compile cleanly (CI failures) that needs to be looked into, maybe you are expected types that doesn't exist on older versions? Suspect this is why you added the new conditional symbol define. Also seem to have file conflict.
The corresponding trunk PR needs to land first. Also, I will adjust the asmdef define constraint when it has landed, since I can't know what it is for sure before that. |
…nto uitech/bugfix/uum-77364-inputsysteminputmodulenonkeyboardnavigation # Conflicts: # Packages/com.unity.inputsystem/CHANGELOG.md # Packages/manifest.json
Trunk PR https://github.cds.internal.unity3d.com/unity/unity/pull/59210 has just landed to 6000.2.0a4, making this PR now testable. |
…nto uitech/bugfix/uum-77364-inputsysteminputmodulenonkeyboardnavigation
Description
Fixed UUM-77364: fixed gamepad navigation in UI Toolkit TextField when using InputSystemUIInputModule.
Testing status & QA
Tested issue and fix manually. Modified unit test to include IsKeyboardNavigationEvent check.
Overall Product Risks
Comments to reviewers
Requires prior landing of trunk PR: https://github.cds.internal.unity3d.com/unity/unity/pull/59210.
Asmdef define for
UNITY_INPUT_SYSTEM_INPUT_MODULE_NON_KEYBOARD
needs to be adjusted once that PR has landed.Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: