Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Select dropdown menu for Path in Input Actions Editor from any position in Path button #2114

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

tspiller
Copy link
Collaborator

@tspiller tspiller commented Jan 27, 2025

Description

Depending on EditorGUIUtility's default label width at the time of window creation, the Path label rect can overlap the Binding Text rect in the Input Actions Editor. Particularly when resolution has been changed and the default has not been updated. This results in both Tooltip text appearing when hovering over the leftmost part of the button and the inability to select the dropdown menu from the button
This change makes the label rect fit to the label itself and recalculates the position of the other elements based on the new width and their positions in the window.

Testing status & QA

Local testing on multiple platforms at different resolutions.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@tspiller tspiller requested review from ekcoh and Pauliusd01 January 28, 2025 10:00
@tspiller tspiller marked this pull request as ready for review January 28, 2025 10:00
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Thanks for actually deriving required space based on text bounds.

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tried editing bindings with different actions assets including project wide actions, with different unity window scaling, different windows display scaling (100-225%), between 2 monitors, auto save on/off, etc. Did not see any issues clicking on the dropdown itself or picking the bindings

@tspiller tspiller merged commit d3eae07 into develop Jan 30, 2025
94 checks passed
@tspiller tspiller deleted the isxb-1309-calcsize-labels-inputcontrolpatheditor branch January 30, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants