Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTT-9216] DA Sample Change sort layer and color of fire prefab to bring it to foreground #250

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Elfi0Kuhndorf
Copy link
Contributor

Description

Change sort layer of fire to bring it to foreground

Issue Number(s)

https://jira.unity3d.com/browse/MTT-9216

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner October 30, 2024 09:26
@gopher-atz
Copy link

looks like this for me:
image
so smoke layer is above fire now, as opposed to the screenshot from the ticket: https://jira.unity3d.com/browse/MTT-9216

@Elfi0Kuhndorf
Copy link
Contributor Author

looks like this for me: image so smoke layer is above fire now, as opposed to the screenshot from the ticket: https://jira.unity3d.com/browse/MTT-9216

Yes, I understood the ticket that way that the smoke renders only behind the fire and that that should be fixed. So I changed the sort layer in order to let the smoke render also in front of the fire.

@Elfi0Kuhndorf
Copy link
Contributor Author

@fernando-cortez Did I interpret the ticket correctly?

NoelStephensUnity and others added 2 commits November 13, 2024 14:49
Updating smoke to render as an alpha texture and blending with the fire.
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, rendering-wise, it looks great.
But I'm not so sure if this fits the same art style anymore? It's very realistic looking flames + smoke, while the rest of the environment is toon shaded & simplified.
Could we add style to it to make it fit the game look?

@Elfi0Kuhndorf
Copy link
Contributor Author

Screenshot 2024-11-18 110804
Fair enough! Do you think that works better or should we remove the basemap of the smoke again, so that the smoke is more gray and simple as it was before?

@fernando-cortez
Copy link
Collaborator

Screenshot 2024-11-18 at 11 28 25

Yeah, the simplicity of what it was before helps here, so we might not need the basemap.

@Elfi0Kuhndorf
Copy link
Contributor Author

How about this?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants