Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding a spawner for the player's avatar in the game scene [MTT-9622] #257

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Nov 18, 2024

Description

This PR moves the spawning of a client's player NetworkObject to a scene NetworkObject. A player's NetworkObject was being spawned conveniently after the scene had been loaded, but this workflow now ensures that the player's NetworkObject is only spawned once it has been synchronized with all the scene's NetworkObjects.

Functionality should remain the same, but instead this scene NetworkBehaviour PlayerSpawner will spawn and position the player at a spawn point.

Issue Number(s)

MTT-9622

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez changed the title feat: adding a spawner for the player's avatar in the game scene feat: adding a spawner for the player's avatar in the game scene [MTT-9622] Nov 18, 2024
@fernando-cortez fernando-cortez marked this pull request as ready for review November 18, 2024 22:17
@fernando-cortez fernando-cortez requested a review from a team as a code owner November 18, 2024 22:17
hammerlerobi
hammerlerobi previously approved these changes Nov 22, 2024
Copy link
Contributor

@hammerlerobi hammerlerobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Fixed some merge conflicts to develop. (Took changes in this PR and readded prefabs needed for TextChat in BootStrap Scene)

…player-spawn

# Conflicts:
#	Basic/DistributedAuthoritySocialHub/Assets/Scenes/Bootstrap.unity
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants