fix: Exception with disabled GameObjects and NetworkTransforms #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/com.unity.netcode.gameobjects into fix/mttb-959-exception-with-disabled-gameobjects
Just keeping the established pattern of using "nameof" within a string. Also added the NetworkTransform's NetworkBehaviourId value as opposed to hard coding the value. (minor tweaks)
NoelStephensUnity
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Had to add a fix for another issue I noticed while reviewing your PR (not due to your PR but that already existed).
Did a minor cosmetic update to the error message generation for LogAssert.Expect.
Other than that, it looks good to me!
As long as my fix didn't break something else! 😝
| @@ -71,8 +71,21 @@ public bool Deserialize(FastBufferReader reader, ref NetworkContext context, int | |||
| if (isSpawnedLocally) | |||
| { | |||
| networkObject = networkManager.SpawnManager.SpawnedObjects[networkObjectId]; | |||
| if (networkObject.ChildNetworkBehaviours.Count <= networkBehaviourId || networkObject.ChildNetworkBehaviours[networkBehaviourId] == null) | |||
| { | |||
| Debug.LogError($"[{nameof(NetworkTransformMessage)}][Invalid] Targeted {nameof(NetworkTransform)}, {nameof(NetworkBehaviour.NetworkBehaviourId)} ({networkBehaviourId}), does not exist! Make sure you are not spawning {nameof(NetworkObject)}s with disabled {nameof(GameObject)}s that have {nameof(NetworkBehaviour)} components on them."); | |||
There was a problem hiding this comment.
Nice wordsmithing...
| var transform = networkObject.ChildNetworkBehaviours[networkBehaviourId] as NetworkTransform; | ||
| if (transform == null) | ||
| { | ||
| Debug.LogError($"[{nameof(NetworkTransformMessage)}][Invalid] Targeted {nameof(NetworkTransform)}, {nameof(NetworkBehaviour.NetworkBehaviourId)} ({networkBehaviourId}), does not exist! Make sure you are not spawning {nameof(NetworkObject)}s with disabled {nameof(GameObject)}s that have {nameof(NetworkBehaviour)} components on them."); |
| @@ -81,8 +94,20 @@ public bool Deserialize(FastBufferReader reader, ref NetworkContext context, int | |||
| } | |||
| else | |||
| { | |||
| // Deserialize the state | |||
| reader.ReadNetworkSerializableInPlace(ref State); | |||
| ownerAuthoritativeServerSide = networkManager.DAHost; | |||
There was a problem hiding this comment.
While reviewing your PR, I noticed a bug in DAHost mode.
Just including the fix for that here.
| @@ -132,7 +151,10 @@ public bool Deserialize(FastBufferReader reader, ref NetworkContext context, int | |||
| ownerClientId = context.SenderId; | |||
| } | |||
|
|
|||
| var networkDelivery = State.IsReliableStateUpdate() ? NetworkDelivery.ReliableSequenced : NetworkDelivery.UnreliableSequenced; | |||
| // Depending upon whether it is spawned locally or not, get the deserialized state | |||
There was a problem hiding this comment.
This is the 2nd part of the fix where State was never being set and it wasn't adjusting based on whether the host, server, or DAHost had a NetworkTransform instance.
| yield return WaitForConditionOrTimeOut(() => ObjectSpawnedOnAllClients(networkObjectInstance.NetworkObjectId)); | ||
| AssertOnTimeout("Timed out waiting for object to spawn!"); | ||
|
|
||
| var errorMessage = $"[Netcode] {nameof(NetworkBehaviour)} index {networkTransformInstance.NetworkBehaviourId} was out of bounds for {m_NonAuthorityPrefab.name}(Clone). " + |
There was a problem hiding this comment.
Minor adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTTB-959
Changelog
GameObjectassociated with aNetworkBehaviour. Do not throw an excpetion.Testing and Documentation