Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: networktransform double lerp (MTTB-539) #3337

Open
wants to merge 46 commits into
base: develop-2.0.0
Choose a base branch
from
Open

fix: networktransform double lerp (MTTB-539) #3337

wants to merge 46 commits into from

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Mar 5, 2025 •
edited
Loading

This PR fixes the issue with double lerping by providing two types of interpolators to select from while also exposing the MaximumInterpolationTime for each respective interpolator type. Smooth Dampening is added as an alternative to using lerp for each respective interpolator (position, rotation, and scale).

This PR includes a few new additions:

  • Additional updates to the inspector view which allows for interpolator type selection and if available additional properties associated with the interpolator.
    image
    image
    image
    image
  • A new NetworkTimeSystem.TickLatency property that provides the average latency of a client.
  • An new NetworkTime.FixedDeltaTimeAsDouble property that returns a double version of the NetworkTime.FixedDeltaTime.

This PR also starts the deprecation process for BufferedLinearInterpolator<T>.Update(float deltaTime, NetworkTime serverTime) as this method is only for internal testing purposes.

MTTB-539
MTT-11338 -- Fixing disabled tests

fix: #3112
close: #3112

Changelog

  • Added: Interpolator types as an inspector view selection for position, rotation, and scale.
  • Added: A new smooth dampening interpolator type that provides a nice balance between precision and smoothing results.
  • Added: NetworkTimeSystem.TickLatency property that provides the average latency of a client.
  • Fixed: Issue where the MaximumInterpolationTime could not be modified from within the inspector view or runtime.
  • Changed: BufferedLinearInterpolator<T>.Update(float deltaTime, NetworkTime serverTime) as being deprecated since this method is only used for internal testing purposes.

Testing and Documentation

  • Includes integration test updates:
    • InterpolatorTests was updated to changes and two disabled tests were refactored and re-enabled.
    • NetworkTransformGeneral includes additional TestFixture passes using Smooth Dampening.
    • NetworktTransformTests includes additional TestFixture passes using Smooth Dampening.
    • NestedNetworkTransformTests includes additional TestFixture passes using Smooth Dampening.
  • Includes updates and additions to public documentation (wip)

@NoelStephensUnity
update
6eadea1 
Some additional updates... still having a hard time getting a single lerp pass without some form of slight jitter.
This includes a temporary 2nd pass lerp that still allows for the buffered item value to be completely reached.
@NoelStephensUnity
update
861dbf1 
Simplifying the new direction and getting all tests to pass.
(still needs a smoother transition between buffered items when not finished interpolating from a previous one)
@NoelStephensUnity
style
d5dfc63 
 adding some needed comments
@NoelStephensUnity
update
45ed0e1 
Still work in progress. Needs some clean up, but it is looking promising.
@NoelStephensUnity
update
2e40494 
The base.OnUpdate is not needed here.
@NoelStephensUnity
update
b784e14 
WIP:
Smooth dampening seems to be working better than any interpolation approach. Still have a minor timing issue, but I believe can be solved....much closer to a more resilient "interpolator".
@NoelStephensUnity
update
08f261c 
Time systems related updates
@NoelStephensUnity
update
4ce6c50 
NetworkTransform and BufferedLinearInterpolator related updates.
@NoelStephensUnity
update
4d691dc 
Minor fixes for recent changes.
@NoelStephensUnity
update
a8a51e2 
some clean up from wip.
@NoelStephensUnity
Merge branch 'develop-2.0.0' into fix/networktransform-double-lerp-MT…
36ed15d 
…TB-539
@NoelStephensUnity
fix
de3094f 
Fixing PVP issues.
@NoelStephensUnity
update
15c8e59 
Adding XML API documentation to some new NetworkTransform properties.
@NoelStephensUnity
fix
283ab9f 
More PVP fun
@NoelStephensUnity
fix
e1f6763 
More and more PVP fun.
@NoelStephensUnity
fix
7b770a4 
Missed two PVP issues.
@NoelStephensUnity
test
6562b90 
Adding Lerp and SmoothDampening to TestFixutres.
@NoelStephensUnity
fix
1cf4f3d 
Putting some things back and realized I should adhere to the original buffered linear interpolator logic/pattern when using Lerp for interpolation to assure there is no impact on users with this update.
@NoelStephensUnity
test
ccd5026 
Made an adjustment to the InterpolatorTests.TestUpdatingInterpolatorWithNoData,.
Also fixed the two tests that were disabled due to no extrapolation.
@NoelStephensUnity
fix
f3d564e 
Minor fix for an issue when dividing up the smooth damp and lerp buffer consumption.
@NoelStephensUnity
update
877f4cc 
Made some more adjustments as well as added a predicted smooth dampened value to help with smoothing and to get closer to the target value on the non-authority side.
Updated the Quaternion's Approximation to use the dot product instead.
@NoelStephensUnity
test
69480f0 
Fixing a bug with one of the tests  (evidently was not caught  using the previous BLI)
@NoelStephensUnity
update
d7f14dc 
Some fixes for the one test that was failing and more TestFixture additions.
@NoelStephensUnity
test
7d02134 
Not sure why these two SetState lerp interpolation tests are having issues as it passes in the editor but fails at runtime... most likely a timing related issue.
@NoelStephensUnity
test and update
fc9ee50 
Clearing out the 2nd rate of change.
Adding delay for the end of the last test in NetworkTransformGeneral.
@NoelStephensUnity
Test
a5d9bf8 
Seeing if this fixes the issue.
@NoelStephensUnity
update
e5dc365 
Minor adjustment to smooth dampening.
@NoelStephensUnity
update
d917530 
adding xml api documentation, tooltips, and some editor adjustments.
@NoelStephensUnity NoelStephensUnity mentioned this pull request Mar 6, 2025
Open
@NoelStephensUnity
style
91eca5f 
removing white space
@NoelStephensUnity
update - pvp
639fbf8 
Adding updates to resolve PVP issues for NetworkTransform.
@NoelStephensUnity
update - pvp
f369d09 
Fixing the remainder of the PVP issues within the components area.
@NoelStephensUnity
style
be8e176 
Fixing minor text issues with the newly added XML API documentation.
@NoelStephensUnity
update
7000fae 
Putting back the T Update(float deltaTime, NetworkTime serverTime) method and marking it as being deprectated.
@NoelStephensUnity
test
0fe85d2 
Adding a smooth dampening pass to the NestedNetworkTransformTests.
@NoelStephensUnity
update
e453cdf 
adding change log entries
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review March 6, 2025 19:16
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner March 6, 2025 19:16
@NoelStephensUnity
Merge branch 'develop-2.0.0' into fix/networktransform-double-lerp-MT…
f649ba4 
…TB-539
@NoelStephensUnity
style
bed3a33 
Adding additional comment on the max delta time calculation.
@NoelStephensUnity
Merge branch 'fix/networktransform-double-lerp-MTTB-539' of https://g…
4121985 
…ithub.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-double-lerp-MTTB-539
@NoelStephensUnity
update
354b036 
Fixing some xml api text issues.
Making sure we are clearing the interpolator when reaching the maximum boundary.
@NoelStephensUnity
update
15a6f9f 
Adding indentions to the new NetworkTransform inspector view properties grouping.
@NoelStephensUnity
Merge branch 'develop-2.0.0' into fix/networktransform-double-lerp-MT…
bdb9586 
…TB-539
@NoelStephensUnity
update
a51365f 
Moving the property field draw method into the NetcodeEditorBase  class in case we wanted to expose it at a later date and/or want to use it for another I-view control.
@NoelStephensUnity
Merge branch 'fix/networktransform-double-lerp-MTTB-539' of https://g…
536da81 
…ithub.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-double-lerp-MTTB-539
@danni-lu danni-lu self-assigned this Mar 7, 2025
@danni-lu danni-lu self-requested a review March 7, 2025 17:50
@NoelStephensUnity
update
ee37977 
Adding final touches to the UI updates for the NetworkTransformEditor.
Also did a PVP pass for all of the editor related classes.
@NoelStephensUnity
update
08dc79a 
Fixing some access permissions and sorting through what we are ready to release as a public API.
@NoelStephensUnity
update
4fe72f5 
Some more adjustments to permissions and some final clean up of BufferedLinearInterpolator<T>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danni-lu danni-lu danni-lu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@danni-lu danni-lu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @danni-lu