Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcs: enable: Generic.Files.LineLength.TooLong #150

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Universal-Omega
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #150 (8c8f04e) into master (7c2bc69) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             master    #150      +/-   ##
===========================================
- Coverage      8.50%   8.47%   -0.04%     
  Complexity     1558    1558              
===========================================
  Files            22      22              
  Lines          4326    4343      +17     
===========================================
  Hits            368     368              
- Misses         3958    3975      +17     
Impacted Files Coverage Δ
includes/Parse.php 0.00% <0.00%> (ø)
maintenance/createTemplate.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2bc69...8c8f04e. Read the comment docs.

@Universal-Omega Universal-Omega marked this pull request as draft July 13, 2022 15:26
if ( Config::getSetting( 'runFromProtectedPagesOnly' ) === true && $title && !$restrictionStore->isProtected( $title, 'edit' ) ) {
// Ideally we would like to allow using a DPL query if the query istelf is coded on a template page which is protected. Then there would be no need for the article to be protected. However, how can one find out from which wiki source an extension has been invoked???
if (
Config::getSetting( 'runFromProtectedPagesOnly' ) === true &&

Check warning

Code scanning / Phpmd (reported by Codacy)

Static access leads to hard to test code

Avoid using static access to class 'MediaWiki\Extension\DynamicPageList3\Config' in method 'parse'.
@@ -59,7 +59,10 @@
$updater = $page->newPageUpdater( User::newSystemUser( 'DynamicPageList3 extension' ) );
$content = $page->getContentHandler()->makeContent( '<noinclude>This page was automatically created. It serves as an anchor page for all \'\'\'[[Special:WhatLinksHere/Template:Extension_DPL|invocations]]\'\'\' of [https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:DynamicPageList3 Extension:DynamicPageList3].</noinclude>', $title );
$updater->setContent( SlotRecord::MAIN, $content );
$comment = CommentStoreComment::newUnsavedComment( 'Autogenerated DynamicPageList3\'s necessary template for content inclusion.' );

$comment = CommentStoreComment::newUnsavedComment(

Check warning

Code scanning / Phpmd (reported by Codacy)

Static access leads to hard to test code

Avoid using static access to class '\CommentStoreComment' in method 'doDBUpdates'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants