Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HookContainer to register hooks #236

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Use HookContainer to register hooks #236

merged 2 commits into from
Apr 22, 2024

Conversation

Universal-Omega
Copy link
Owner

@Universal-Omega Universal-Omega commented Jul 8, 2023

Manipulating $wgHooks is deprecated

Fixes #235

@codecov-commenter
Copy link

Codecov Report

Merging #236 (5472b66) into master (66c441c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage     10.83%   10.83%           
+ Complexity     1571     1565    -6     
=========================================
  Files            23       23           
  Lines          4265     4264    -1     
=========================================
  Hits            462      462           
+ Misses         3803     3802    -1     
Impacted Files Coverage Δ
includes/Parse.php 0.00% <0.00%> (ø)

@tyrann0us
Copy link

Hi @Universal-Omega, thanks for the PR! Do you have any plans to merge this or are there still any known issues?
The deprecating errors are "spamming" my logs, so a fix would be greatly appreciated.
Thank you very much!

@Universal-Omega
Copy link
Owner Author

Hi @Universal-Omega, thanks for the PR! Do you have any plans to merge this or are there still any known issues? The deprecating errors are "spamming" my logs, so a fix would be greatly appreciated. Thank you very much!

@tyrann0us

It just that this is untested if your able to test I can merge otherwise it will take a little while longer for me to be able to test...

@tyrann0us
Copy link

@Universal-Omega, thanks for getting back to me. I applied the fix from this PR to the extension sometime after my above comment, and while I only use DPL for one very basic query, the deprecation notices stopped showing up in the logs. Therefore, this should be good to go.

BTW, the referenced issue (#235) also mentions Deprecated: ParserOutput::mCategories public read access deprecated, which I also see a lot in my logs. It was fixed in #215 already. Do you have an ETA for a new release of DynamicPageList3 that will include both fixes?
Thank you!

@Universal-Omega Universal-Omega merged commit 24bb50d into master Apr 22, 2024
@Universal-Omega Universal-Omega deleted the hookContainer branch April 22, 2024 09:14
@Universal-Omega
Copy link
Owner Author

I will probably make a new release either this week or next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several deprecation notices on hooks
3 participants