PageImages support for mode=gallery on non file pages #275
Conversation
|
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Extra context: This was originally written around 2022 for a wiki in MW1.35. During a recent update cleaned up the code a bit and tested it on a blank install of MW1.41. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $img = $repoGroup->findFile( Title::makeTitle( NS_FILE, $pageImage ) ); | ||
| if ( $img && $img->exists() ) { | ||
| $imageUrl = $img->getURL(); | ||
| } else { |
Check warning
Code scanning / Phpmd (reported by Codacy)
Use return statements instead of else expression Warning
Co-authored-by: CosmicAlpha <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
Co-authored-by: CosmicAlpha <[email protected]>
…try to alphabetical order
|
Thank you for all the fixes and formatting! |
| $img = $repoGroup->findFile( Title::makeTitle( NS_FILE, $pageImage ) ); | ||
| if ( $img && $img->exists() ) { | ||
| $imageUrl = $img->getURL(); | ||
| } else { |
Check warning
Code scanning / Phpmd (reported by Codacy)
Use return statements instead of else expression Warning
| // Failed to get a page image | ||
| $item = $this->getItemStart() . $item . $this->itemEnd . '[[' . $item . ']]'; | ||
| } | ||
| } else { |
Check warning
Code scanning / Phpmd (reported by Codacy)
Use return statements instead of else expression Warning
| if ( $pageImage ) { | ||
| // Successfully got a page image, wrapping it | ||
| $item = $this->getItemStart() . $pageImage . '| [[' . $item . ']]' . $this->itemEnd . 'link=' . $item; | ||
| } else { |
Check warning
Code scanning / Phpmd (reported by Codacy)
Use return statements instead of else expression Warning
Universal-Omega
merged commit df4ff96
into
Universal-Omega:master
In gallery mode, attempting to automatically detect whether:
If both are true, it should try to use the PageImage for the gallery and the page name for the image caption.
Right now, it also makes the page name in the caption a link, and points the image link to the page as well. Could not figure out how to make this behavior optional.
Gallery mode for file pages should be untouched.
Notes: