Fix remaining validation errors #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator was reporting 167 warnings regarding use of flat:foreign. This patch resolves all of those. It also includes various other fixes that I made along the way, but hopefully nothing controversial — sorry to mix it all up together.
In terms of the flat:foreign stuff, the three options for handling "foreign" material are laid out here:
https://universaldependencies.org/foreign.html
I followed "Option 2" in most cases which seems to make the most sense, and is closest to the way things were annotated already.
Option 3 was more appropriate in a small number of cases where the English text was something like a full quoted phrase vs. a proper name that played a syntactic role in the otherwise Irish sentence. See for example the quoted phrase "that general Jail-Deliverer" in sent_id=85, or "Kill me, I Love You!" in sent_id=201.