Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RealTimeBox #1189

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Update RealTimeBox #1189

merged 2 commits into from
Nov 25, 2024

Conversation

christophfroehlich
Copy link
Contributor

The deprecation notice did not work because the header file changed #fail

ros-controls/realtime_tools#146

@christophfroehlich christophfroehlich mentioned this pull request Nov 23, 2024
Closed
4 tasks
@urfeex
Copy link
Member

urfeex commented Nov 25, 2024

Thank you for catching up with this! It looks like CI has been started before the merge was done in realtime tools. I'll restart builds and see again.

@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented Nov 25, 2024 •
edited
Loading

Exactly, I just realized that afterwards that ros2_controllers repo is broken as well.
The main branch of this repo should be fine since the last PR in realtime_tools, maybe you want to wait for merging this until a new version of realtime_tools got released.

@urfeex
Copy link
Member

urfeex commented Nov 25, 2024

I rather have working semi-binary builds than binary-testing builds as binary-testing is also tested by the buildfarm. Since without this merged, all semi-binary builds for jazzy and rolling break, I will merge this.

urfeex
urfeex approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good and semi-binary builds are successful.

Thanks @christophfroehlich for directly addressing this!

@urfeex urfeex merged commit 4ad0056 into UniversalRobots:main Nov 25, 2024
7 of 12 checks passed
@urfeex
Copy link
Member

urfeex commented Nov 25, 2024

@Mergifyio backport humble

@mergify Mergify
Copy link

mergify bot commented Nov 25, 2024 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@christophfroehlich @mergify
ur_controllers: Update RealTimeBox (#1189)
b1e3549 
The realtime_box API has been changed. This PR updates the controllers to that update.

(cherry picked from commit 4ad0056)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Closed
URJala pushed a commit to URJala/Universal_Robots_ROS2_Driver that referenced this pull request Dec 20, 2024
@christophfroehlich @urmahp
ur_controllers: Update RealTimeBox (UniversalRobots#1189)
05877a2 
The realtime_box API has been changed. This PR updates the controllers to that update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urfeex urfeex urfeex approved these changes

Assignees
No one assigned
Labels
backport-humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @urfeex