Skip to content

Commit

Permalink
fix: device count flag without variant (#8773)
Browse files Browse the repository at this point in the history
  • Loading branch information
Tymek authored Nov 15, 2024
1 parent 2ffff25 commit 6d4e2e9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,13 @@ import type { FC } from 'react';
import { IconCell } from 'component/common/Table/cells/IconCell/IconCell';
import WarningIcon from '@mui/icons-material/WarningAmber';
import { Tooltip } from '@mui/material';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import { useVariant } from 'hooks/useVariant';

type UserSessionsCellProps = {
count?: number;
};

export const UserSessionsCell: FC<UserSessionsCellProps> = ({ count }) => {
const { uiConfig } = useUiConfig();
const minimumCountToShow = useVariant<number>(
uiConfig.flags.showUserDeviceCount,
);

if (!count || count < (minimumCountToShow ? minimumCountToShow : 5)) {
if (!count || count < 5) {
return null;
}

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/interfaces/uiConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export type UiFlags = {
'enterprise-payg'?: boolean;
simplifyProjectOverview?: boolean;
productivityReportEmail?: boolean;
showUserDeviceCount?: Variant;
showUserDeviceCount?: boolean;
flagOverviewRedesign?: boolean;
};

Expand Down
1 change: 1 addition & 0 deletions frontend/src/interfaces/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export interface IUser {
addedAt?: string;
accountType?: AccountType;
scimId?: string;
activeSessions?: number;
}

export interface IPermission {
Expand Down

0 comments on commit 6d4e2e9

Please sign in to comment.