Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename toggle to flag #8854

Merged
merged 2 commits into from
Nov 26, 2024
Merged

chore: rename toggle to flag #8854

merged 2 commits into from
Nov 26, 2024

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Nov 26, 2024

No description provided.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 7:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 7:54am

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@@ -59,7 +59,7 @@ test('Import happy path', async () => {

const codeEditorLabel = screen.getByText('Code editor');
codeEditorLabel.click();
const editor = screen.getByLabelText('Exported toggles');
const editor = screen.getByLabelText('Exported features');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"flags" or "features"? Maybe feature flags?

@sjaanus sjaanus merged commit 7906bfb into main Nov 26, 2024
11 of 12 checks passed
@sjaanus sjaanus deleted the toggle-to-flag branch November 26, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants