Skip to content

Commit

Permalink
merge master changes
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Smith <[email protected]>
  • Loading branch information
EspadaV8 committed Jan 31, 2024
1 parent 0a44894 commit 10ea4b5
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 12 deletions.
3 changes: 3 additions & 0 deletions source/file_size_metrics/changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
**<span style="color:#56adda">0.1.1</span>**
- Include an underline for the file names to make the clickability clearer

**<span style="color:#56adda">0.1.0</span>**
- New layout to try and make better use of space

Expand Down
2 changes: 1 addition & 1 deletion source/file_size_metrics/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
"on_postprocessor_task_results": 0
},
"tags": "data panel",
"version": "0.1.0"
"version": "0.1.1"
}
22 changes: 13 additions & 9 deletions source/file_size_metrics/static/css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -115,26 +115,26 @@ html {
}

.charts {
max-height: 450px;
max-height: 550px;
}

.tables {
display: grid;
display: flex;
gap: 10px;
grid-template-columns: 2fr 1fr;
padding-top: 20px;
}

#individual_file_size_chart {
flex-grow: 1;
order: 2;
overflow: hidden;
}

#individual_file_size_chart .card {
position: relative;
}

#history_completed_tasks_table_wrapper {
flex-grow: 2;
order: 1;
}

Expand All @@ -158,36 +158,40 @@ html {
background: var(--q-positive);
}

.q-badge.success::after {
.q-badge.success:after {
content: "Success";
}

.q-badge.failed {
background: var(--q-negative);
}

.q-badge.failed::after {
.q-badge.failed:after {
content: "Failed";
}

.basename .name {
text-decoration: underline dashed;
}

/* Responsive columns */
@media screen and (max-width: 940px) {
.top-content {
position: inherit;
}

.q-badge.success::after {
.q-badge.success:after {
content: "✔";
}

.q-badge.failed::after {
.q-badge.failed:after {
content: "✖";
}

.tables {
padding-top: 0;
gap: 0;
grid-template-columns: 1fr;
flex-wrap: wrap;
}

#individual_file_size_chart {
Expand Down
4 changes: 2 additions & 2 deletions source/file_size_metrics/static/js/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ const viewConversionDetails = (jobId) => {
const CompletedTasksDatatable = (function () {
const recordName = (basename, type, { task_success } = row) => {
if (task_success) {
return `<div class="q-badge success"></div> ${basename}`;
return `<span class="q-badge success"></span> <span class="name" title="View Details">${basename}</span>`;
}

return `<div class="q-badge failed"></div> ${basename}`;
return `<span class="q-badge failed"></span> <span class="name" title="View Details">${basename}</span>`;
};

const buildTable = () => {
Expand Down

0 comments on commit 10ea4b5

Please sign in to comment.