Correct regex escaping for renaming subtitle tags #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit for this goes to https://github.com/bambanah The online python tester I used didn't correctly check the escaping of the `\`, so they actually need to be doubled up (see: Unmanic#349 (comment)). I have tested this with a Python REPL and can confirm that the previous code does have an issue and the updated code works.
|
This can't be merged without incrementing the plugin version |
Ah yes, sorry, you mentioned that in Discord but I forgot. Bumped what I assume is the correct version number 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit for this goes to https://github.com/bambanah
The online python tester I used didn't correctly check the escaping of the
\, so they actually need to be doubled up (see: #349 (comment)).I have tested this with a Python REPL and can confirm that the previous code does have an issue and the updated code works.