Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve added support for BigDataBowl data. The implementation of the
AmericanFootballGraphConverter
converter uses a different approach thanSoccerGraphConverter
(previouslyGraphConverter
). Since it relies on Polars instead of Kloppy.The API works in a very similar manner, but some parameters are different between
AmericanFootballGraphConverter
andSoccerGraphConverter
both because the sports are fundamentally different and because the data comes from different sources.These differences can be seen in Graphs FAQ, Section B
All computed node features and edge features can be found in Graphs FAQ, Section C. Compared to the soccer implementation we now also include, for example:
Additionally we provide a
BigDataBowlDataset
class to easily load all relevant data sources into theAmericanFootballGraphConverter
via thedataset
parameter, and to add labels and dummy graph ids. TheBigDataBowlDataset
requires 3 parameters, namely:This PR also includes tests for the American Football implementation and some other minor fixes for the Soccer implementation. As well as an abstraction from
GraphConverter
toDefaultGraphConverter
which is now inherited by bothAmericanFootballGraphConverter
andSoccerGraphConverter
.Under the hood the same logic follow for
DefaultGraphSettings
.The minor fixes include: