feat: monero-native integration (FFI C wrapper) #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #114
Motivation
Currently we are dependent on
monero-wallet-rpc
which causes a few issues:monero-wallet-rpc
process on exit #21)monero-wallet-rpc
on startup which introduces complexityWe want to replace this with native bindings. We use the Rust FFI bindings to
monero_c
. @sneurlax is working on in this PRwallet2.h
which is the backbone for monero_cTODO, in no specific order
monero-wallet-rpc
in the code with references to themonero_c
rust bindingsMONERO_Wallet_checkTxKey
(See: Rust develop MrCyjaneK/monero_c#103 (comment))monero-wallet-rpc
with a feature flag. This could be useful for theasb
or for our integration tests. However I'm leaning strongly towards removing support entirely.monero_c
for ourmonero-harness
cratemonero-rpc
cratewallet2
in-and-out.unwrap()
calls